refactor height filter to appease cppcheck & MSVC (#473)
authortsteven4 <13596209+tsteven4@users.noreply.github.com>
Sun, 26 Jan 2020 15:26:58 +0000 (08:26 -0700)
committerGitHub <noreply@github.com>
Sun, 26 Jan 2020 15:26:58 +0000 (08:26 -0700)
commit340fffd6baf2bbd1661f16c84092870afd7e19df
treef213ab66b89a917fa6b7d3a90407e658e7b3e95c
parente483407cf11a45cc0e80acf9c34784cbc47f8bae
refactor height filter to appease cppcheck & MSVC (#473)

* refactor heightgrid to appease cppcheck.

With newer versions (somwhere after 1.82) of cppcheck analyzing
height.cc took an excessive amount of time.
By making these variables private static class members instead of
member function static variables we avoid the cppcheck issues.

* tweak height to work around MSVC 2017 error.

and hopefully MSVC 2015 error as well.

* don't include cstdint within class definition.

It can lead to compile failures.  This was done in heightgrid.h,
but the include guards in cstdint hid the error.
.codacy.yaml
height.cc
height.h
heightgrid.h
tools/createGeoidGrid